feat(node): configure ntx script cache size via clap #1454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergerad
reviewed
Jan 4, 2026
sergerad
reviewed
Jan 6, 2026
sergerad
reviewed
Jan 6, 2026
crates/ntx-builder/src/lib.rs
Outdated
| const COMPONENT: &str = "miden-ntx-builder"; | ||
|
|
||
| pub const DEFAULT_SCRIPT_CACHE_SIZE: NonZeroUsize = | ||
| NetworkTransactionBuilder::DEFAULT_SCRIPT_CACHE_SIZE; |
Collaborator
There was a problem hiding this comment.
We don't need this do we?
sergerad
reviewed
Jan 6, 2026
crates/ntx-builder/src/builder.rs
Outdated
| /// Each cached script contains the deserialized `NoteScript` object, so the actual memory usage | ||
| /// depends on the complexity of the scripts being cached. | ||
| const DEFAULT_SCRIPT_CACHE_SIZE: NonZeroUsize = NonZeroUsize::new(1000).unwrap(); | ||
| pub const DEFAULT_SCRIPT_CACHE_SIZE: NonZeroUsize = NonZeroUsize::new(1000).unwrap(); |
Collaborator
There was a problem hiding this comment.
This doesn't need to be pub does it?
Contributor
Author
There was a problem hiding this comment.
This doesn't need to be pub does it?
Made changes
Mirko-von-Leipzig
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reopen #1340
Fixes #1335